refactor(storagenode): committer to remove requireCommitWaitTasks parameter #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
- Coverage 80.22% 80.04% -0.18%
==========================================
Files 178 178
Lines 21505 21484 -21
==========================================
- Hits 17252 17197 -55
- Misses 3474 3500 +26
- Partials 779 787 +8 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
bbcb5b1 to
3e1d1de
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
75d32d4 to
b74daea
Compare
hungryjang
approved these changes
Feb 1, 2025
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
3e1d1de to
176898b
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
b74daea to
efdf19f
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
176898b to
a5563c6
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
efdf19f to
d89b402
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
a5563c6 to
2c91418
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
d89b402 to
39badb5
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
2c91418 to
d038320
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
39badb5 to
6a78fac
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
d038320 to
f0e2f6d
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
6a78fac to
836ae8b
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
f0e2f6d to
0112600
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
836ae8b to
1467dc3
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
0112600 to
8b14788
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
1467dc3 to
11e60ba
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
8b14788 to
6b9b962
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
11e60ba to
769148b
Compare
Removed the llsnList from the replicateTask to improve performance and simplify the code. The beginLLSN field is now used instead. This change eliminates the need to fill llsnList, resulting in a slight performance improvement.
Removed dead code that was commented out. This improves code readability and maintainability by eliminating dead code.
…ameter This PR removes the requireCommitWaitTasks parameter from the commitInternal method. The parameter was used to support sync replication, which is the recovery between two replicas in a log stream. However, sync replication doesn't use commitInternal anymore.
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
6b9b962 to
b193b68
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
769148b to
c62ffc5
Compare
ijsong
deleted the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the requireCommitWaitTasks parameter from the commitInternal
method. The parameter was used to support sync replication, which is the
recovery between two replicas in a log stream. However, sync replication doesn't
use commitInternal anymore.