perf(logstream): remove llsnList from replicateTask #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
==========================================
- Coverage 80.22% 80.02% -0.20%
==========================================
Files 178 178
Lines 21505 21493 -12
==========================================
- Hits 17252 17200 -52
- Misses 3474 3502 +28
- Partials 779 791 +12 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
07bb027 to
ddda877
Compare
ijsong
force-pushed
the
remove_llsnlist_from_replicatetask
branch
from
ce900c8 to
63587a4
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
ddda877 to
c805615
Compare
ijsong
force-pushed
the
remove_llsnlist_from_replicatetask
branch
from
63587a4 to
881dbd6
Compare
hungryjang
approved these changes
Feb 20, 2025
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
c805615 to
d694a78
Compare
ijsong
force-pushed
the
remove_llsnlist_from_replicatetask
branch
from
881dbd6 to
0edb558
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
d694a78 to
c70817c
Compare
ijsong
force-pushed
the
remove_llsnlist_from_replicatetask
branch
from
0edb558 to
b7b91b7
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
c70817c to
d309674
Compare
ijsong
force-pushed
the
remove_llsnlist_from_replicatetask
branch
from
b7b91b7 to
85624ca
Compare
Removed the llsnList from the replicateTask to improve performance and simplify the code. The beginLLSN field is now used instead. This change eliminates the need to fill llsnList, resulting in a slight performance improvement.
ijsong
force-pushed
the
remove_llsnlist_from_replicatetask
branch
from
85624ca to
171469b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removed the llsnList from the replicateTask to improve performance and simplify
the code. The beginLLSN field is now used instead. This change eliminates the
need to fill llsnList, resulting in a slight performance improvement.