xpadneo, init: Do not report paddles unconditionally

SDL2 author @slouken pointed out that the bitmap cannot be properly
tested for the existence of the XBE2 paddles. This commit fixes that by
first testing if the paddles exist in the bitmap, and only then enable
the remaining three paddles. The underlying problem is that the HID
descriptor does not have a properly defined bitmap for the paddles but
a single 4-bit value instead.

See-also: atar-axis#428
Signed-off-by: Kai Krakow <kai@kaishome.de>

hid-xpadneo/src/hid-xpadneo.c

@@ -874,11 +874,12 @@ static int xpadneo_input_configured(struct hid_device *hdev, struct hid_input *h
 	/* do not report the keyboard buttons as part of the gamepad */
 	__clear_bit(BTN_SHARE, xdata->gamepad->keybit);
 
-	/* add paddles as part of the gamepad */
-	__set_bit(BTN_PADDLES(0), xdata->gamepad->keybit);
-	__set_bit(BTN_PADDLES(1), xdata->gamepad->keybit);
-	__set_bit(BTN_PADDLES(2), xdata->gamepad->keybit);
-	__set_bit(BTN_PADDLES(3), xdata->gamepad->keybit);
+	/* ensure all four paddles exist as part of the gamepad */
+	if (test_bit(BTN_PADDLES(0), xdata->gamepad->keybit)) {
+		__set_bit(BTN_PADDLES(1), xdata->gamepad->keybit);
+		__set_bit(BTN_PADDLES(2), xdata->gamepad->keybit);
+		__set_bit(BTN_PADDLES(3), xdata->gamepad->keybit);
+	}
 
 	return 0;
 }