added bytes::Buf and bytes::BufMut support to Ring #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlsverre
commented
May 9, 2024
| } | ||
|
|
||
| fn chunk_mut(&mut self) -> &mut UninitSlice { | ||
| UninitSlice::new(self.as_write_slice(usize::MAX)) |
There was a problem hiding this comment.
this is probably the weirdest part of the BufMut API, but as documented here ::new is used for initialized memory. https://docs.rs/bytes/latest/bytes/buf/struct.UninitSlice.html#method.new
|
Hey @carlsverre, thanks so much for the PR! Sorry I've been unable to get some eyes on this, but I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to have native Buf and BufMut support for easier integration between vmap::Ring and prost. You can find prost here: https://github.com/tokio-rs/prost
Documentation on traits:
Happy to move the code around, add tests, or change features. Not sure how you'd like these kinds of extensions to work.
And thanks for such an awesome crate!