Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Twing #555

Closed
wants to merge 3 commits into from
Closed

Switch to Twing #555

wants to merge 3 commits into from

Conversation

RobLoach
Copy link
Contributor

@RobLoach RobLoach added the WIP Work in Progress label Feb 19, 2018
@thiagodemellobueno
Copy link
Contributor

@RobLoach can you elaborate o what we get by doing this that we otherwise don't?

@RobLoach RobLoach closed this Jun 4, 2018
@andrewmallis
Copy link
Member

@RobLoach – did you answer @thiagodemellobueno offline?
What is twing? What problem are we solving?

@RobLoach
Copy link
Contributor Author

RobLoach commented Jun 4, 2018

While Twig.js is great, there are some inconsistencies in the output. We have differences between how Drupal outputs a component vs how Kalastatic outputs a component. Using Twing would output the exact same result in either KSTAT or Drupal.

I closed this for now because Twing.js is still pretty young. Perhaps I'll consider it again down the line, but for now, Twig.js is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants