Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed absolute path used in voxforge eg script. #1483

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

baali
Copy link
Contributor

@baali baali commented Mar 8, 2017

No description provided.

@danpovey
Copy link
Contributor

danpovey commented Mar 8, 2017

hm, that directory was supposed to be an example, better to set it to something that just doesn't exist and let the user decide. and you could clarify in the comment at the top of run.sh that DATA_ROOT is set in path.sh.

@baali
Copy link
Contributor Author

baali commented Mar 8, 2017

There is already a comment in run.sh related to setting DATA_ROOT in path.sh:
# 1. Setting the DATA_ROOT variable to point to a directory with enough free
So you would rather comment out export DATA_ROOT line itself?
export DATA_ROOT="$KALDI_ROOT/egs/voxforge/s5/voxforge" # e.g. something like /media/secondary/voxforge
And later there is a if check in path.sh on this variable which prompts user to set it correctly.

@danpovey
Copy link
Contributor

danpovey commented Mar 8, 2017 via email

@baali
Copy link
Contributor Author

baali commented Mar 9, 2017

Just fixed that.

@danpovey
Copy link
Contributor

danpovey commented Mar 9, 2017

and change run.sh to mention that DATA_ROOT is in path.sh, e.g. change
Setting the DATA_ROOT variable to point to a directory with enough free
to
Setting the DATA_ROOT variable in path.sh to point to a directory with enough free

@danpovey danpovey merged commit 5bfa9e5 into kaldi-asr:master Mar 9, 2017
@baali
Copy link
Contributor Author

baali commented Mar 9, 2017

Sorry for that mixup in comment grammar.

@danpovey
Copy link
Contributor

danpovey commented Mar 9, 2017

thanks.

kronos-cm added a commit to kronos-cm/kaldi that referenced this pull request Mar 16, 2017
* 'master' of https://github.com/kaldi-asr/kaldi:
  [build] Bump OpenFst version to v1.6.2 (kaldi-asr#1492)
  [src] nnet1: fixing issue in multi-task training (kaldi-asr#1491)
  [egs] Fixes to URLs in vystadial example script.
  [egs] Minor cosmetic changes in voxforge example script (kaldi-asr#1483)
  [scripts,egs] sMBR on LFR xent system with shifted feats (kaldi-asr#1477)
  [src] bug-fix in gst plugin code (issue on g++ 5.4.0) (kaldi-asr#1479)
david-ryan-snyder pushed a commit to david-ryan-snyder/kaldi that referenced this pull request Apr 12, 2017
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants