-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed absolute path used in voxforge eg script. #1483
Conversation
hm, that directory was supposed to be an example, better to set it to something that just doesn't exist and let the user decide. and you could clarify in the comment at the top of run.sh that DATA_ROOT is set in path.sh. |
There is already a comment in run.sh related to setting DATA_ROOT in path.sh: |
but the comment in run.sh doesn't say where it is.
yes, it might be best to just comment out the line.
…On Wed, Mar 8, 2017 at 2:05 PM, baali ***@***.***> wrote:
There is already a comment in run.sh related to setting DATA_ROOT in
path.sh:
# 1. Setting the DATA_ROOT variable to point to a directory with enough
free
So you would rather comment out export DATA_ROOT line itself?
export DATA_ROOT="$KALDI_ROOT/egs/voxforge/s5/voxforge" # e.g. something
like /media/secondary/voxforge
And later there is a if check in path.sh on this variable which prompts
user to set it correctly.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1483 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJVuwEqrflNq3Y5B_xyhx-Y3U6ugBqyks5rjwnvgaJpZM4MXG_q>
.
|
Just fixed that. |
and change run.sh to mention that DATA_ROOT is in path.sh, e.g. change |
Sorry for that mixup in comment grammar. |
thanks. |
* 'master' of https://github.com/kaldi-asr/kaldi: [build] Bump OpenFst version to v1.6.2 (kaldi-asr#1492) [src] nnet1: fixing issue in multi-task training (kaldi-asr#1491) [egs] Fixes to URLs in vystadial example script. [egs] Minor cosmetic changes in voxforge example script (kaldi-asr#1483) [scripts,egs] sMBR on LFR xent system with shifted feats (kaldi-asr#1477) [src] bug-fix in gst plugin code (issue on g++ 5.4.0) (kaldi-asr#1479)
No description provided.