Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wasm-pack to js dependency #206

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Sep 1, 2024

I found that building this locally failed due to a missing dependency on wasm-pack. Added the npm version of this package as a dev dependency.

npm run build

> ezno@0.0.22 build
> wasm-pack build --dev --out-dir src/js-cli-and-library/build --target web --no-pack && npm run build-js

sh: wasm-pack: command not found

@kaleidawave
Copy link
Owner

🤦‍♂️ I often install global for these tools and then forget when I publish them.

Awesome, am away for laptop this week. Will double check and merge next week.

@rotu
Copy link
Contributor Author

rotu commented Sep 14, 2024

@kaleidawave don't forget about this PR, please!

@kaleidawave kaleidawave added bug Something isn't working internal-improvements Related to internal publishing, building, workflows, formatting & linting js-wasm-unplugin-and-playground The JS library, Unplugin NPM packages and playground labels Sep 15, 2024
@kaleidawave kaleidawave merged commit 8ce921e into kaleidawave:main Sep 15, 2024
9 of 10 checks passed
@kaleidawave
Copy link
Owner

kaleidawave commented Sep 15, 2024

Thanks for the change! Also good that this removes some steps in CI.

The formatting error in CI is because of an update to rustfmt in the latest Rust release. Will fix in dedicated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal-improvements Related to internal publishing, building, workflows, formatting & linting js-wasm-unplugin-and-playground The JS library, Unplugin NPM packages and playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants