Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for disjoint stuff #209

Merged
merged 25 commits into from
Nov 13, 2024
Merged

Fixes for disjoint stuff #209

merged 25 commits into from
Nov 13, 2024

Conversation

kaleidawave
Copy link
Owner

@kaleidawave kaleidawave commented Sep 29, 2024

  • Change over intersection to use disjoint function
  • More fixes to disjoints and types
  • Change ranges back to use LessThan and GreaterThan

Ignore branch name

- Change over intersection to use disjoint function
- Also add valgrind to performance and size (WIP improvements to be made in the future)
@kaleidawave kaleidawave added bug Something isn't working checking Issues around checking labels Sep 29, 2024
@kaleidawave
Copy link
Owner Author

Changed range back, now getting some weird and complex types :(

---- specification::operators::disjoint_equality_for_number_intrinsics stdout ----
Running Disjoint equality for number intrinsics
thread 'specification::operators::disjoint_equality_for_number_intrinsics' panicked at checker/specification/test.rs:127:9:
Diff < left / right > :
 [
<    "This equality is always false as InclusiveRange<0, 5> & Integer and 2.2 have no overlap",
<    "This equality is always false as InclusiveRange<0, 5> & Integer and 7 have no overlap",
>    "This equality is always false as GreaterThan<0> & LessThan<5> & Integer | 0 & Integer | 5 & Integer and 2.2 have no overlap",
 ]


---- specification::operators::ranges_after_operators stdout ----
Running Ranges after operators
thread 'specification::operators::ranges_after_operators' panicked at checker/specification/test.rs:127:9:
Diff < left / right > :
 [
<    "Expected null, found InclusiveRange<-5, 5>",
<    "Expected string, found InclusiveRange<18, 22>",
>    "Cannot GreaterThan<-1> & LessThan<1> | -1 | 1 Multiply 5",
>    "Expected null, found any",
>    "Cannot GreaterThan<-1> & LessThan<1> | -1 | 1 Add 10",
>    "Expected string, found any",
 ]


---- specification::operators::ranges_for_interal_types stdout ----
Running Ranges for interal types
thread 'specification::operators::ranges_for_interal_types' panicked at checker/specification/test.rs:127:9:
Diff < left / right > :
 [
<    "Expected string, found boolean",
>    "Cannot GreaterThan<-1> & LessThan<1> | -1 | 1 GreaterThan -2",
>    "Expected true, found any",
>    "Cannot GreaterThan<-1> & LessThan<1> | -1 | 1 GreaterThan -1",
>    "Expected string, found any",
 ]

@kaleidawave kaleidawave added the compiler-performance Making parsing / type checking / transformations faster label Oct 21, 2024
- Run performance-and-size automatically on PRs with compiler-performance label
- Change "features" around on checker-specification
- Narrowing fix
- Remove ast-explorer and REPL from WASM build
- Change JS tests
- Removing lexing from ast-explorer
- Fixes a bit more intrinsics
- Extract helpers and operator modules
- Fix disjoint warning for !==
- Remove intermediate operation
- More range fixes
- Literal on object
- Indentation in specification
- Disjoint on template literals
- Move specification tests
@kaleidawave kaleidawave marked this pull request as ready for review November 13, 2024 17:20
}
}

#[derive(Debug)]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a bit of a upgrade to @sor4chi s work on #218 because wanted a bit more of an abstraction to catch disjoint issues.

@@ -770,6 +770,47 @@ a satisfies 0; b satisfies string;

- Expected string, found 1

#### Array map
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it seems I broke the event recording inside .map and other iteration based things. Will come back to at some point

- add number_intrinsics options (+ rename)
- fix typo in specification
@kaleidawave
Copy link
Owner Author

Not 100% on this merge. Some concerns

  • Type checking performance seems to be slightly down after this
  • Still haven't full figured out the perf-difference calculating in the CI (haven't got artifact across runs working)
  • Lost some important tests around iteration (.map & Object methods seem to be broken). Although I think PR Add iteration and other events related things #187 is the place to fix those.

CI is green and have to have these changes in the release for the blog so merging now!

Branch name is also outdated. Not a simple fix so whatever

@kaleidawave kaleidawave merged commit dab8faf into main Nov 13, 2024
3 of 9 checks passed
@kaleidawave kaleidawave deleted the improve-generics-and-fixes branch November 13, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checking Issues around checking compiler-performance Making parsing / type checking / transformations faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant