Add app in top level config

[steventsao]

• updated readme
• updated tests to handle the new config

[steventsao]

Resolves #2.

[simonihmig]

Thanks @steventsao, this looks very good!

This is a breaking change, as any old (flat) config would not work with the new approach, right?
I guess you could provide an upgrade path, by supporting both formats and deprecating the previous one. But tbh, I am not that much worried about it, we can certainly just bump the minor version and tell users how to upgrade...

What I am really surprised about is that the blueprint test is not failing! It seems you (rightly) changed the default blueprint, but forgot to update the test fixture (https://github.com/kaliber5/ember-cli-bundlesize/blob/master/node-tests/fixtures/config/bundlesize.js). No big deal, but I really don't understand why this was not failing the test!? 🤔

[steventsao]

What I am really surprised about is that the blueprint test is not failing! It seems you (rightly) changed the default blueprint, but forgot to update the test fixture (https://github.com/kaliber5/ember-cli-bundlesize/blob/master/node-tests/fixtures/config/bundlesize.js). No big deal, but I really don't understand why this was not failing the test!? 🤔

It looks like the test only passed because emberGenerate was used incorrectly and the assertion had timed out. The function returns a promise and does not take a callback that returns a file. I've moved the assertion to after the promise resolves and to compare their buffers instead. LMK what you think!

[simonihmig]

It looks like the test only passed because emberGenerate was used incorrectly and the assertion had timed out.

Seems you are right, thanks for investigating!

I've moved the assertion to after the promise resolves and to compare their buffers instead.

I prefer not to compare buffers, but still use the file helper for that. As in the examples. What's missing in the examples is the part to import the file helper, which can be done like here. Would you be able to update that accordingly?

[steventsao]

Done. the error case looks much better than using buffer.

AssertionError: expected "config/bundlesize.js" to equal "/.../../fixtures/config/bundlesize.js"
      + expected - actual

       'use strict';

       module.exports = {
      -  app: {
      +  appppppp: {

[simonihmig]

Looks awesome, thank you!

[simonihmig]

Published as 0.1.0! 🎉