Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flash message test support from addon #21

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Use flash message test support from addon #21

merged 1 commit into from
Aug 5, 2020

Conversation

simonihmig
Copy link
Member

@simonihmig simonihmig commented Aug 5, 2020

Instead of our equivalent home-grown solution, which has no benefits AFAICT.

Instead of our equivalent home-grown solution, which has no benefits.
@simonihmig simonihmig requested a review from lolmaus August 5, 2020 11:38
@simonihmig simonihmig merged commit 1cd6ae3 into master Aug 5, 2020
@simonihmig simonihmig deleted the flash branch August 5, 2020 11:50
@lolmaus
Copy link
Contributor

lolmaus commented Aug 17, 2020

This removes the custom flash messages initializer, but where is the equivalent that you mention in title & description?

@simonihmig
Copy link
Member Author

When you install enber-cli-flash its default blueprint adds something to test-helpers.js that basically makes the addon behave as we had it before in test mode. See:

@simonihmig simonihmig added the enhancement New feature or request label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants