Bugfix/ws-econnreset - fixes #106 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I see yarn workspaces removed the |
Yeah, that's best. Allows us to focus our discussion. |
EECOLOR
reviewed
Mar 17, 2018
| const wss = new ws.Server({ port }) | ||
| wss.on('connection', ws => { | ||
| ws.on('error', err => { |
There was a problem hiding this comment.
Did you check that the error was caught here?
There was a problem hiding this comment.
My environment had 100% failure which was fixed by this commit.
klaasman
force-pushed
the
bugfix/ws-econnreset
branch
from
76280ac to
8b98489
Compare
EECOLOR
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess we could split this PR up into two PR's since most of the files are touched for enabling yarn workspaces.
Your call if we should or shouldn't.