Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patromo pr/handle type erros in filterbank #128

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Patromo pr/handle type erros in filterbank #128

merged 3 commits into from
Jun 17, 2019

Conversation

sanmai
Copy link
Collaborator

@sanmai sanmai commented Jun 17, 2019 •
edited
Loading

  • I've run the tests with vendor/bin/phpunit
  • None of the tests were found failing
  • I've seen the coverage report at build/coverage/index.html
  • Not a single line left uncovered by tests
  • Any coding standards issues were fixed with vendor/bin/php-cs-fixer fix

Fixes #126

Fixes #127

PATROMO and others added 3 commits June 14, 2019 10:55
@PATROMO
Add wrapper for call_user_func_array() with try/catch block.
aa26c48 
Catch TypeError and rethrow LiquidException because Filter is called
with too few arguments.
A LiquidException is more meaningful as TypeError and developer can
handle this like liquid template error.
@PATROMO
Add test case to confirm that LiquidException is throw.
eed1cea 
When filter are called with too few arguments.
@sanmai
Take care of TypeError from within the Context.
a195370 
This reverts commit aa26c48.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.912% when pulling a195370 on sanmai:PATROMO-pr/handle-type-erros-in-filterbank into 034d499 on kalimatas:master.

@sanmai sanmai merged commit cade20c into kalimatas:master Jun 17, 2019
@sanmai
Copy link
Collaborator Author

sanmai commented Jun 17, 2019

Thank you @PATROMO

@sanmai sanmai deleted the PATROMO-pr/handle-type-erros-in-filterbank branch June 17, 2019 07:30
@PATROMO
Copy link

PATROMO commented Jun 17, 2019

@sanmai thank you too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If you use filter without required argument then php throw Type Error.
3 participants
@sanmai @coveralls @PATROMO