Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: htmlentities() shouldn't be called with null #218

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Fix: htmlentities() shouldn't be called with null #218

merged 3 commits into from
Oct 4, 2024

Conversation

fedeisas
Copy link

@fedeisas fedeisas commented Oct 3, 2024 •
edited
Loading

Fix: htmlentities(): Passing null to parameter #1 ($string) of type string is deprecated

  • I've run the tests with vendor/bin/phpunit
  • None of the tests were found failing
  • I've seen the coverage report at build/coverage/index.html
  • Not a single line left uncovered by tests
  • Any coding standards issues were fixed with vendor/bin/php-cs-fixer fix

@sanmai
Copy link
Collaborator

sanmai commented Oct 3, 2024

How can I get you to add unit test for this change?

@fedeisas
Copy link
Author

fedeisas commented Oct 4, 2024

@sanmai ✅

@fedeisas
Copy link
Author

fedeisas commented Oct 4, 2024

thanks @sanmai

@sanmai sanmai merged commit 3a472d5 into kalimatas:master Oct 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedeisas @sanmai