Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color-alpha span height is too short in WordPress 5.3 #31

Closed
webaware opened this issue Oct 23, 2019 · 4 comments
Closed

color-alpha span height is too short in WordPress 5.3 #31

webaware opened this issue Oct 23, 2019 · 4 comments
Labels
bug

Comments

@webaware
Copy link

WordPress 5.3 changes some admin styling for improved accessibility. In WP 5.3, the color-alpha span is now too short -- 24px in a 26px hole -- and the transparent background cross-hatch shows through at the bottom of the span. PR coming.
webaware added a commit to webaware/wp-color-picker-alpha that referenced this issue Oct 23, 2019
@webaware
change color-alpha span height to 100%
47d791f 
fixes kallookoo#31
@webaware webaware mentioned this issue Oct 23, 2019
Closed
@theDanielJLewis
Copy link

I see this in my WordPress as well.

@neilgee
Copy link

neilgee commented Mar 19, 2020

I see this too - but should be 28px

Screen Shot 2020-03-19 at 1 47 39 pm

@neilgee
Copy link

neilgee commented Mar 19, 2020

Oh I see you set the fix to 100%, good stuff

kallookoo added a commit that referenced this issue Mar 19, 2020
@kallookoo
Fix issue [#31]
e5a6154
@kallookoo kallookoo added the bug label Mar 19, 2020
@kallookoo
Copy link
Owner

Update all files for this change
Thanks @webaware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change color-alpha span height to 100% webaware/wp-color-picker-alpha
4 participants
@theDanielJLewis @kallookoo @webaware @neilgee