Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing code coverage #4

Merged
merged 10 commits into from
Jul 29, 2020
Merged

Increasing code coverage #4

merged 10 commits into from
Jul 29, 2020

Conversation

tweisser
Copy link
Collaborator

@tweisser tweisser commented Jul 28, 2020 •
edited by kalmarek
Loading

TODO

  • fix Alt(4) example
  • add tests for characters.jl

@codecov
Copy link

codecov bot commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #4 into master will increase coverage by 21.21%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   56.73%   77.94%   +21.21%     
===========================================
  Files           6        6               
  Lines         208      204        -4     
===========================================
+ Hits          118      159       +41     
+ Misses         90       45       -45
Flag Coverage Δ
#unittests 77.94% <95.23%> (+21.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/gf.jl 91.66% <95.00%> (+53.66%) ⬆️
src/eigenspacedecomposition.jl 94.56% <100.00%> (ø)
src/ccmatrix.jl 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5306873...2a70504. Read the comment docs.

@tweisser tweisser marked this pull request as draft July 28, 2020 16:33
@tweisser tweisser requested a review from kalmarek July 28, 2020 16:34
@kalmarek
Copy link
Owner

that is a nice trick with using Pkg; Pkg.add(...) ;-)

@kalmarek
Copy link
Owner

but I don't think there's much to test with characters for now; I'll add more tests for GFs though

@tweisser
Copy link
Collaborator Author

Does the FiniteFields implementation work for q = p^n?

@kalmarek
Copy link
Owner

Does the FiniteFields implementation work for q = p^n?

No, but I didn't want to add isprime check to the constructor, it's too heavy.

kalmarek
kalmarek approved these changes Jul 28, 2020
View reviewed changes
Copy link
Owner

@kalmarek kalmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you have something you'd like to see added/changed here?

@tweisser
Copy link
Collaborator Author

No, I think we can merge now and do the characters.jl after we have added cyclotomics.

@tweisser tweisser marked this pull request as ready for review July 29, 2020 00:25
@tweisser tweisser merged commit 835db32 into master Jul 29, 2020
blegat pushed a commit to blegat/SymbolicWedderburn.jl that referenced this pull request Jul 4, 2021
@kalmarek
Merge pull request kalmarek#4 from kalmarek/enh/numberconstructors
82cc71c 
run TagBot every hour
@kalmarek kalmarek deleted the codecov branch September 1, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalmarek kalmarek kalmarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tweisser @kalmarek