Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-independent small_idempotents iterators #51

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Conversation

kalmarek
Copy link
Owner

@kalmarek kalmarek commented Oct 25, 2022

we now reset the iterator to make it iterable multiple times and iterate (in Iterators.product) over independent copies

This is slightly heavier but correct ;)

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 86.10% // Head: 86.39% // Increases project coverage by +0.29% 🎉

Coverage data is based on head (d9119e8) compared to base (5d88715).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d9119e8 differs from pull request most recent head 40aa645. Consider uploading reports for the commit 40aa645 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   86.10%   86.39%   +0.29%     
==========================================
  Files          17       17              
  Lines        1101     1110       +9     
==========================================
+ Hits          948      959      +11     
+ Misses        153      151       -2     
Flag Coverage Δ
unittests 86.39% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/matrix_projections.jl 79.34% <ø> (ø)
src/minimal_projections.jl 93.75% <100.00%> (+3.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kalmarek kalmarek merged commit 6868855 into master Oct 25, 2022
@kalmarek kalmarek deleted the mk/fix_mps branch October 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant