General improvements #135
Merged
General improvements #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 3, 2017 18:31
…hread to make sure no unpredictable behavior happens.
…unctions to make sure they are dealt with on main thread. * Removed `isDestroyed` flag from `AVPlayerEngine` wasn’t necessary. * Added comments and improved some logs.
# Conflicts: # Classes/Player/AVPlayerEngine/AVPlayerEngine.swift
ElizaSapir
approved these changes
Apr 4, 2017
srivkas
added a commit
that referenced
this pull request
Apr 22, 2017
…Core * commit '785e68df381105dee0e75fef1fe18d700f864c66': add supported version under CC sdk dependency (#143) replace raw value to asString (#141) Fem 1333 (#140) FEM-1318 (#139) FEM-1320 (#138) Fem 1311 (#136) General improvements (#135) # Conflicts: # Classes/Providers/OTT/Services/OTTAssetService.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DispatchQueue.main.asynccalls to play, pause and destroy functions to make sure they are dealt with on main thread.AppStateSubjectobservation.isDestroyedflag fromAVPlayerEngine- wasn’t necessary.