FEM-1261 #144
Merged
FEM-1261 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gal-orlanczyk
commented
Apr 23, 2017
gal-orlanczyk
commented
- Added delayed prepare for ads player decorator.
- Added discard checks for IMAPlugin ads playing to know when to discard ads.
added 5 commits
April 17, 2017 10:55
* Renamed 3 properties in `PKAdInfo` according to their naming in IMA SDK to be aligned.
# Conflicts: # Classes/PKStateMachine.swift # Plugins/IMA/AdsEnabledPlayerController.swift # Plugins/IMA/AdsPlugin.swift # Plugins/IMA/IMAConfig.swift # Plugins/IMA/IMAPlugin.swift
ElizaSapir
suggested changes
Apr 23, 2017
| guard canPlayAd(forState: currentState) else { return } | ||
| self.start(adsManager: adsManager) | ||
| if shouldDiscardAd() { | ||
| PKLog.debug("discard Ad Break") |
There was a problem hiding this comment.
@gal-orlanczyk why self.discardAdBreak is no called here?
There was a problem hiding this comment.
We can't discardAdBreak in adBreakReady because no ad have been loaded yet, when we don't call .start() on ad break it is like discarding, if we will call discard here it will discard the next adBreak which is unwanted behavior.
ElizaSapir
approved these changes
Apr 24, 2017
noamtamim
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.