Fev 468 moderate plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
semarche-kaltura
commented
Mar 1, 2020
semarche-kaltura
commented
eitanavgil
suggested changes
Mar 3, 2020
| } | ||
| .playkit-player.playkit-size-ty { | ||
| .kaltura-moderation__root { | ||
| display: none; |
There was a problem hiding this comment.
This makes the entire scree be gone when the player is too little. it has a bit of a weird behavior. Let's discuss maybe with Dana
| <CloseButton onClick={onClick} /> | ||
| <div className={styles.mainWrapper}> | ||
| <div className={[styles.title, 'kaltura-moderation__title'].join(' ')}>What’s wrong with this content?</div> | ||
| <Popover |
There was a problem hiding this comment.
I think that at some point we will need a drop down as a 'native' drop-down component as checkbox inputs textArea and other forms element. Let's consult @esakal if we shoule make this a contrib thing
| reportLength: 500, | ||
| onReportSentMessage: 'Send report', | ||
| onReportErrorMessage: 'The report failed to send', | ||
| moderateOptions: [ |
There was a problem hiding this comment.
This does not work when configuration is passed from the embed / uiconf definitions
There was a problem hiding this comment.
opened a core ticket
https://kaltura.atlassian.net/browse/FEC-9716
eitanavgil
approved these changes
Mar 11, 2020
| reportLength: 500, | ||
| onReportSentMessage: 'Send report', | ||
| onReportErrorMessage: 'The report failed to send', | ||
| moderateOptions: [ |
There was a problem hiding this comment.
opened a core ticket
https://kaltura.atlassian.net/browse/FEC-9716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.