doc(update-guide):Share user guide update #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
requested changes
Oct 26, 2022
README.md
Outdated
| * Whether to add also start postion to the shared media | ||
|
|
||
| #### useNative | ||
| * If the share icon is clicked users will have the ability to choose how to share the desired content using plauer custom UI or the native share api |
There was a problem hiding this comment.
you mean, this is what happens if useNative is true or...?
| * If the share icon is clicked users will have the ability to choose how to share the desired content using plauer custom UI or the native share api | ||
|
|
||
| #### shareOptions | ||
| `shareOptions` are optional, the plugin can work only with shareUrl or embedUrl stand alone |
There was a problem hiding this comment.
doesn't shareUrl override shareOptions url ?
README.md
Outdated
|
|
||
| #### Example | ||
|
|
||
| **[Share Plugin Example](https://codepen.io/giladna/pen/KKoOrLV)** |
There was a problem hiding this comment.
I don't know if I would use a codepen link. isn't it possible to host a demo in this project itself ?
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.