feat(FEC-10015): support smart scrubber preview and timeline marker #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2020
Merged
yairans
commented
Dec 8, 2020
yairans
commented
Dec 10, 2020
src/timeline.js
Outdated
| } | ||
|
|
||
| _onAdManifestLoaded(e: any): void { | ||
| const adBreaksPosition = e.payload.adBreaksPosition; |
Merged
5 tasks
yairans
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Dec 10, 2020
…359) * Expose the new api's `registerManager`, `getManager` and `hasManager` * Fix the `KPUIComponent` Related to kaltura/playkit-js-ui#546, kaltura/playkit-js-timeline#1, kaltura/playkit-js-ima#178 Solves FEC-10015
yairans
added a commit
to kaltura/playkit-js-ui
that referenced
this pull request
Dec 10, 2020
…546) #### News: * New `Managers` class which exposes the `registerManager(name, manager)`, `getManager(name)` and `hasManager(name)`. #### Changes * Add `PlayerArea` in the `Seekbar` component allows to push the cue points and to replace the default seekbar preview * Move the seekbar preview element to `SeekBarPreview` component to be replaceable * Don't show the default seekbar preview when cue-point hovering (by new state `cuePointActive`) * Ignore the seekbar mouse events when the seekbar/cue-point preview hovering (by new state `previewHoverActive`) * Don't show the time bubble if the seekbar/cue-point preview hide it (by new state `hideTimeBubble`) * Move the `virtualTime` to the store to be accessible from the `CuePoint` * Add the seekbar client rect to the store to be accessible from the `CuePoint` for position calculation * Expose some css variables to reuse in java-script * `PlayerArea` passes the replaced component props to the override component (used in seekbar preview overriding) * `PlayerArea` gets new `shouldUpdate` prop to enforce updating the children (used for cue points which should get the seekbar changes) Related to kaltura/kaltura-player-js#359, kaltura/playkit-js-timeline#1 Solves FEC-10015
yairans
added a commit
to kaltura/playkit-js-ima
that referenced
this pull request
Dec 10, 2020
…178) use the new `addCuePoint` for the ad breaks when configured Depends on kaltura/playkit-js-timeline#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timelineplugin.TimelineManagerclass which exposes:addCuePoint,removeCuePointandsetSeekbarPreview.CuePointcomponent.adBreakCuePointconfigdepends on:
kaltura/kaltura-player-js#359
kaltura/playkit-js-ui#546
Solves FEC-10015