fix(SUP-46391): Player Live Full Screen Bug when browser window is not maximized #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yambenari24
requested review from
lianbenjamin,
SivanA-Kaltura,
MosheMaorKaltura and
semarche-kaltura
SivanA-Kaltura
requested changes
Jan 23, 2025
src/components/shell/shell.tsx
Outdated
| @@ -212,7 +213,7 @@ class Shell extends Component<any, any> { | |||
| */ | |||
| componentDidMount() { | |||
| const {player, eventManager} = this.props; | |||
| eventManager.listen(window, 'resize', debounce(this._onWindowResize, ON_PLAYER_RECT_CHANGE_DEBOUNCE_DELAY)); | |||
| eventManager.listen(window, 'resize', debounce(this._onWindowResize, RESIZE_DEBOUNCE_DELAY)); | |||
There was a problem hiding this comment.
this fix is only for fullscreen, right ?
There was a problem hiding this comment.
Only full screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When browser width is small, side pannel is on, and enter full screen, there is a gap between side pannel and player.
Fix:
Fix timing issue : the issue related to the timing of the DOM updates. When resizing the window or triggering an actions that affect the layout, the client rect of the player container getBoundingClientRect() is not updated immediately after the resize. This causes discrepancies between the actual layout and the values being used in the state.
solved SUP-46391