Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-46391): Player Live Full Screen Bug when browser window is not maximized #982

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

MosheMaorKaltura
Copy link
Collaborator

Reverts #981

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ser wind…"

This reverts commit adad585.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@MosheMaorKaltura MosheMaorKaltura merged commit b769450 into master Feb 15, 2025
11 checks passed
@MosheMaorKaltura MosheMaorKaltura deleted the revert-981-revert-976-SUP-46391 branch February 15, 2025 10:00
MosheMaorKaltura pushed a commit that referenced this pull request Feb 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
### Description of the Changes

bugfix, regression from
[fix](#982).

**Issue:**
player crushes when executing `updatePlayerClientRect` with an undefined
`playerContainer`.

**Fix:**
execute `updatePlayerClientRect` only if `playerContainer` exists.

#### Resolves CR-317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant