fix(ADA-1745) - Create alternative aria-label for close button #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinStoicaK
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Feb 25, 2025
src/components/overlay/overlay.tsx
Outdated
| @@ -155,7 +155,10 @@ class Overlay extends Component<OverlayProps, any> { | |||
| props.onClose(); | |||
| }} | |||
| onKeyDown={this.onCloseButtonKeyDown} | |||
| aria-label={(<Text id="overlay.close" />) as unknown as string} | |||
| aria-label={ | |||
| props.closeAriaLabel || | |||
There was a problem hiding this comment.
where is this value being set ?
There was a problem hiding this comment.
closeAriaLabel is an optional prop that is set when needed. For now I am setting it in Video Info and Downloads.
There was a problem hiding this comment.
I would recommend use (<Text id="overlay.close" />) as unknown as string as default property of closeAriaLabel. Then you can use aria-label={props.closeAriaLabel}
valentinStoicaK
changed the title
semarche-kaltura
approved these changes
Mar 10, 2025
semarche-kaltura
requested changes
Mar 10, 2025
src/components/overlay/overlay.tsx
Outdated
| @@ -155,7 +155,10 @@ class Overlay extends Component<OverlayProps, any> { | |||
| props.onClose(); | |||
| }} | |||
| onKeyDown={this.onCloseButtonKeyDown} | |||
| aria-label={(<Text id="overlay.close" />) as unknown as string} | |||
| aria-label={ | |||
| props.closeAriaLabel || | |||
There was a problem hiding this comment.
I would recommend use (<Text id="overlay.close" />) as unknown as string as default property of closeAriaLabel. Then you can use aria-label={props.closeAriaLabel}
semarche-kaltura
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves https://kaltura.atlassian.net/browse/ADA-1745
Related to kaltura/playkit-js-info#112 and kaltura/playkit-js-downloads#84
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Issue:
Fix:
Resolves FEC-[Please add the ticket reference here]