Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set aria-live attribute to 'assertive' for playkit-subtitles element #408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set aria-live attribute to 'assertive' for playkit-subtitles element #408

wants to merge 1 commit into from

Conversation

joaalto
Copy link

@joaalto joaalto commented Oct 15, 2019 •
edited
Loading

Description of the Changes

After this screen readers will read the subtitles then they are updated.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@joaalto
Set aria-live attribute to 'assertive' for playkit-subtitles element,…
ac35a41 
… so that screen readers will read the subtitles then they are updated.
@joaalto
Copy link
Author

joaalto commented Oct 15, 2019

Ping @OrenMe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joaalto