Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Soft-reset adds module commands each time #576

Closed
shreeve opened this issue May 12, 2023 · 1 comment · Fixed by #577
Closed

[BUG] Soft-reset adds module commands each time #576

shreeve opened this issue May 12, 2023 · 1 comment · Fixed by #577
Assignees
@communix
Milestone
1.1.0-beta.2

Comments

@shreeve
Copy link
Contributor

shreeve commented May 12, 2023

When typing .help after first launching the REPL, we see:

> .help
.help	Print this help message
.hi	Print welcome message
.echo	Echo on/off
.reset	Soft reset
.flash	Commands for flash
.load	Load code from flash
.mem	Heap memory status
.gc	Perform garbage collection
.ls	List files
.pwd	Print current directory
.cd	Change current directory
.mkdir	Create directory
.rm	Remove file or directory
.cat	Print the content of file

But, each time we do a soft reset, any module commands (not the default REPL commands) get added again, like this:

> .help
.help	Print this help message
.hi	Print welcome message
.echo	Echo on/off
.reset	Soft reset
.flash	Commands for flash
.load	Load code from flash
.mem	Heap memory status
.gc	Perform garbage collection
.ls	List files
.pwd	Print current directory
.cd	Change current directory
.mkdir	Create directory
.rm	Remove file or directory
.cat	Print the content of file
.ls	List files
.pwd	Print current directory
.cd	Change current directory
.mkdir	Create directory
.rm	Remove file or directory
.cat	Print the content of file

For each reset, we get the .ls through .cat commands added another time.
@shreeve
Copy link
Contributor Author

shreeve commented May 12, 2023

I've got a fix for this and will submit a PR now

shreeve added a commit to shreeve/kaluma that referenced this issue May 12, 2023
@shreeve
Don't keep adding module commands to the help menu after soft reset (f…
c421dc7 
…ixes kaluma-project#576)
@shreeve shreeve mentioned this issue May 12, 2023
Merged
shreeve added a commit to shreeve/kaluma that referenced this issue May 12, 2023
@shreeve
Don't keep adding module commands to the help menu after soft reset (f…
4df6186 
…ixes kaluma-project#576) (#2)
@communix communix self-assigned this May 14, 2023
@communix communix added this to the 1.1.0-beta.2 milestone May 14, 2023
shreeve added a commit to shreeve/kaluma that referenced this issue May 15, 2023
@shreeve
Revert "Don't keep adding module commands to the help menu after soft…
5545262 
… reset (fixes kaluma-project#576) (#2)"

This reverts commit 4df6186.
shreeve added a commit to shreeve/kaluma that referenced this issue May 15, 2023
@shreeve
Squashed commit of the following:
223e366 
commit c4d4f26
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Mon May 15 12:52:29 2023 -0600

    Revert "Allow --rev=REVISION to tag a revision to a build file"

    This reverts commit 395b972.

commit 5545262
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Mon May 15 12:52:18 2023 -0600

    Revert "Don't keep adding module commands to the help menu after soft reset (fixes kaluma-project#576) (#2)"

    This reverts commit 4df6186.

commit 225ec56
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Mon May 15 12:52:09 2023 -0600

    Revert "Normalize some of the keystrokes in the REPL"

    This reverts commit 9df496e.

commit 9b3b586
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Mon May 15 12:52:04 2023 -0600

    Revert "Make the soft reset a little more pronounced when it's done"

    This reverts commit ae3f4e4.

commit c0b7f5c
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Sat May 13 00:24:12 2023 -0600

    Use all cores when building

commit ae3f4e4
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Fri May 12 00:20:47 2023 -0600

    Make the soft reset a little more pronounced when it's done

commit 9df496e
Author: Steve Shreeve <steve.shreeve@gmail.com>
Date:   Fri May 12 00:20:14 2023 -0600

    Normalize some of the keystrokes in the REPL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@communix communix

Labels
None yet
Projects
None yet
Milestone
1.1.0-beta.2
Development

Successfully merging a pull request may close this issue.

Don't keep adding module commands to the help menu after soft reset shreeve/kaluma
2 participants
@shreeve @communix