Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of invalid filenames and directory names #2

Closed
khalim19 opened this issue Jun 27, 2014 · 1 comment
Closed

Improve handling of invalid filenames and directory names #2

khalim19 opened this issue Jun 27, 2014 · 1 comment
Assignees

Comments

@khalim19
Copy link
Collaborator

Each platform (Windows, Unix, ...) has different sets of disallowed characters in filenames. So it would seem that deleting different invalid characters on each platform would be a good idea. However, many "exotic" characters on Unix platforms have apparently been more trouble than it's worth.

At the end of the day, it may be a good idea to leave the current allowed character set as-is to keep things simple.

On Windows, don't allow some "reserved" words to be in filenames (however unlikely it is that the user names the layers like that):
http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29

@khalim19 khalim19 self-assigned this Jun 27, 2014
@khalim19
Copy link
Collaborator Author

Resolved by using StringValidator subclasses (for filenames, directories and file extensions) from the pylibgimpplugin library.

yfede pushed a commit to yfede/gimp-plugin-export-layers that referenced this issue Jul 22, 2015
…at gets added by GIMP at the end of layer whose name already is used somewhere else in the drawing.
khalim19 added a commit that referenced this issue May 18, 2016
If tag modification resulted in the layer name being changed by GIMP (usually appending " #1", " #2", etc.), update the whole preview. Renaming just one layer could result in renaming other layers, hence the preview would be out of sync with the real export results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant