-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover batched XHR cancelling with tests #1742
Conversation
627a4f1
to
5d8f5bc
Compare
Now that |
@kamilkisiela since this is mostly adding new test cases, it should be relatively fast to review. Do you think it could get merged ? |
d187125
to
6b106a5
Compare
Rebased. Because CI pipeline changed after this PR was created it looks like some jobs are still pending. But actually everything that need to pass does indeed pass. @kamilkisiela would you have an opportunity to review this ? |
6b106a5
to
406165b
Compare
@kamilkisiela since you spent a bit of time on this lib recently, maybe you'd have time to review this (rebased) PR ? |
This is dependent on apollographql/apollo-client#9248, so it is not strictly specific to `apollo-angular`, but it seemed important to ensure that this package does indeed allow to cancel XHR even when batching is enabled.
406165b
to
3d6b79e
Compare
@PowerKiKi do you want to maintain the library? :) |
say Yes and I click "merge" :) |
Yes 😃 But I'd like to ask a few you question before if you actually step down from being a maintainer. Such as why did you recently re-introduce ApolloModule ? and why would you step down ? |
@PowerKiKi do you use Slack? If so, are you okay with joining The Guild's #apollo-angular channel? It would be easier to discuss things. In short, I'm not stepping down, it's just that I'm too busy with other things and this project needs some love. |
I don't usually use slack, but I will if necessary. I can't find the URL for Slack anywhere though.... |
I need to invite you, it's not a public slack. Can share your email address with me, over email (to not expose it here)? |
Checklist:
This is dependent on apollographql/apollo-client#9248, so it is not strictly specific to
apollo-angular
, but it seemed important to ensure that this package does indeed allow to cancel XHR even when batching is enabled.There is no changelog entries, because there not change at all for end-users.
It should only be merged after a new apollo-client is released (and after updating our lock file).