Custom tsconfig path for the build command, default to tsconfig.build.json and fallback to tsconfig.json
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: af5928e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
enisdenjo
requested review from
ardatan,
n1ru4l and
kamilkisiela
and removed request for
ardatan
1 task
ardatan
approved these changes
Feb 15, 2023
enisdenjo
changed the title
tsconfig.build.json and fallback to tsconfig.json
n1ru4l
approved these changes
Mar 1, 2023
n1ru4l
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #190
However, sometimes you might have multiple config files and use one for build. One common reason is one tsconfig checks the types of all files (including other configs and tests) and another tsconfig specifies what is to be built.
This PR allows for a
--tsconfigoption to directly specify the tsconfig to use.TODO
tsconfig.build.jsonand then fallback totsconfig.json(decide should it be? - it should)