Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic dead lock #123

Closed
cyriltovena opened this issue Oct 6, 2018 · 2 comments
Closed

panic dead lock #123

cyriltovena opened this issue Oct 6, 2018 · 2 comments
Assignees
@kamilsk
Labels
type:critical

Comments

@cyriltovena
Copy link

If action panic then the done channel is never closed and it hangs forever.

retry/retry.go

Line 42 in 272c537

close(done)

@kamilsk kamilsk self-assigned this Oct 6, 2018
kamilsk added a commit that referenced this issue Oct 6, 2018
@kamilsk
fix issue #123: fix critical runtime fault with unhandled panic in Re…
21779a3 
…try goroutine
@kamilsk
Copy link
Owner

kamilsk commented Oct 6, 2018 •
edited
Loading

@Kuqd, thank you for reporting! fixed by 21779a3

@kamilsk kamilsk closed this as completed Oct 6, 2018
@cyriltovena
Copy link
Author

Glad I could help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilsk kamilsk

Labels
type:critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyriltovena @kamilsk