#5 - Refactoring - extract directory representation to data model, instead of regular dictionary #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --no-input argument so the app can be run with all input prompts surpassed, e.g. to not crash github actions. Also added basic unit testing framework so it's easier to modularize and test code in the future.
frogermcs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge: #4 before merging this one!
This Pull Request migrates from dictionary data model for directory structure into regular datamodel.
It's the first step to extract logic from app.py to external modules (#5 ) so it's easier to reuse it in different projects.
Also the app's code is a bit more cleaner.
I added some unit tests as well.