Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for floating point types are missing #519

Closed
rolandjohann opened this issue Mar 2, 2018 · 4 comments
Closed

Support for floating point types are missing #519

rolandjohann opened this issue Mar 2, 2018 · 4 comments

Comments

@rolandjohann
Copy link

As far as I can see all metrics only provide Long arguments. Is there any reason for this?

@rolandjohann
Copy link
Author

Yust to clarify things: Is there any maintainer on this project? I u derstand that issue solving takes time, but andwering to issues shouldn‘t take two weeks, though.

We really want to use Kamon for monitoring but not having double values is a blocker.

@ivantopo
Copy link
Contributor

Hey @rolandjohann, the main reason for only having Long values has been the usage of the HdrHistogram internally since loong time ago. Additionally, most of the signals that we are tracking with Kamon can be successfully tracked with longs: Latency in nanoseconds, counts and queue sizes.. there have been a few situations in which it would be desirable to have double values, like when talking about CPU usage, load averages and maybe even user-defined metrics that make sense as floating point values, but this hasn't been a priority nor a problem to us nor to the majority of the community, I only recall this coming up a handful of times in the 4+ years that Kamon has been around.

May I ask what is your use case and why having floating point values is a blocker?

And, to address your other question: Yes, there are maintainers in this project, I am one of them. @dpsoft is another, and several people stay close to what we are doing here. We do the best we can with the time we have available to improve Kamon, reply to questions and keep the project moving forward, but things sometimes just slip through the cracks. In those cases I encourage you to drop a new message, mention Diego or me, or going to the gitter channel. It might take time to get a response since we work on Kamon during our free time, but if we didn't reply just insist and we will find the time.

@rolandjohann
Copy link
Author

rolandjohann commented Mar 18, 2018 via email

@ivantopo
Copy link
Contributor

I'm closing this issue because it is either too old to be relevant or stale. Stop by our Github Discussions section and drop a message if you need any additional help with the topic.

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants