Allow configuration of the percentile metrics to submit in Datadog API reporter #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that adding the p99 would be a good addition, but I wouldn't just add it as a default because that one additional metric could have a significant effect on people's bills because they are counted as custom metrics. Could you please change the implementation so that we read a list of percentiles from config (similar to how the influxdb reporter does here: https://github.com/kamon-io/Kamon/blob/master/reporters/kamon-influxdb/src/main/resources/reference.conf#L16) and default to only the p95 so that it behaves the same after people upgrade? |
|
Makes sense. Will try to improve this in the upcoming days... |
thyandrecardoso
force-pushed
the
add-p99
branch
2 times, most recently
from
5c29a25
to
f086e14
Compare
|
@ivantopo Hi, can you take a look at this again please? |
thyandrecardoso
changed the title
thyandrecardoso
force-pushed
the
add-p99
branch
from
f086e14
to
832f6fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only p95 gets reported. Looking at p99 seems a fairly common and important use case. I tested this by making sure that these changes work against our Datadog account and I see the new metric.
Can we report p99 as well?