This repository has been archived by the owner on May 27, 2021. It is now read-only.
Remove assertions when mapping value to countsArray index #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since index calculated here is used to construct a compacted histogram snapshot and not index the actual counts array, we are removing the assertions that would prevent index overflowing backing-histogram's dynamic range. This is required in order to pack gauge values as histograms since gauges are not capped by backing-histogram's maxTrackableValue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since index calculated here is used to construct a compacted histogram snapshot
and not index the actual counts array, we are removing the assertions that would
prevent index overflowing backing-histogram's dynamic range.
This is required in order to pack gauge values as histograms since gauges are not
capped by backing-histogram's maxTrackableValue