This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Add the ability to override metric details via config. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new class `MetricOverrideReporter`, that allows users to: - Rename metrics. - Delete tags associated with a metric. - Rename tags associated with a metric.
|
Hey @GlassAndOneHalf @fazy! Folks, I'm sorry that I missed this PR, just came to this module because of the upgrade to Kamon 2.0 and realized that this PR is waiting for so long! And, what is worst, it is a really awesome feature to have! This is something so useful that should probably be part of core :), just tried it out and seems to be working fine. Thanks a lot for the efforts! |
|
Released it as 1.1.2, now on its way to maven central! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in kamon-io/Kamon#536, this commit adds a new class
MetricOverrideReporter, that allows users to:This PR was done in collaboration with @fazy and inspired by similar work in kamon-io/kamon-datadog#22