Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated create-react-app to create-next-app in React roadmap #4612

Closed

Conversation

AmineAouragh
Copy link

According to the issue #4580 the React roadmap still has create-react-app as a React CLI tool to create new React projects. But as of now the React team no longer recommends using create-react-app but instead recommends picking one of the React-powered frameworks popular in the community like Next.js so i updated the React CLI to create-next-app.

@AbdelrhmanX7
Copy link
Contributor

Hey @AmineAouragh, this should be a simple task that only requires a single file change, but I noticed that around 17 files have been modified, and most of them are unrelated to the issue.

@AmineAouragh
Copy link
Author

AmineAouragh commented Oct 25, 2023

Yeah absolutely you are right. I just don't understand why commits from other pull requests are being added in this pull request. There is a problem.

@AbdelrhmanX7
Copy link
Contributor

AbdelrhmanX7 commented Oct 26, 2023

1- you need to sync your master fork with the developer-roadmap master branch
2- when you create a new branch do this
- git checkout -b your-branch-name origin/master (don't forget to stash save any uncommit files)
- git pull origin master (to update your branch with master base)

@arikchakma
Copy link
Collaborator

@AmineAouragh Can you please resolve the conflicting files? It could have been just one file.

@alinkedd
Copy link

alinkedd commented Nov 5, 2023

@AmineAouragh
Next.js is already located in Frameworks group.
I suggest we should either remove CRA completely or replace it with Parcel as it's mentioned in docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants