Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamu-api-server: error if specialized config is not found + kamu-dev-api-server: image #149

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

s373r
Copy link
Member

@s373r s373r commented Oct 18, 2024

⚠️ Please add the image to the repository:

Package kamu-dev-api-server
https://github.com/orgs/kamu-data/packages/container/package/kamu-dev-api-server

image

@s373r s373r self-assigned this Oct 18, 2024
@s373r s373r changed the title Chore/s3 external address kamu-api-server: error if specialized config is not found + Oct 18, 2024
@s373r s373r changed the title kamu-api-server: error if specialized config is not found + kamu-api-server: error if specialized config is not found + kamu-api-server:dev images Oct 18, 2024
@s373r s373r marked this pull request as ready for review October 18, 2024 17:04
@s373r s373r requested review from zaychenko-sergei and sergiimk and removed request for zaychenko-sergei October 18, 2024 17:04
cp ../../target/$(TARGET)/release/kamu-api-server tmp/kamu-api-server
docker build \
--build-arg KAMU_VERSION=$(KAMU_VERSION) \
-t $(IMAGE_REPO)/kamu-api-server:$(TAG) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to clearly separate prod and dev images and I think tag is insufficient because:

  • Dev image uploads will relate to the same GH "package" as prod images
    • Harder for users to see the version history
    • If there will be ever image push notifications - we'll be spamming people with dev builds
  • Makes it harder to clean up dev images over time - will need some tag-based regexes

In GHCR we cannot create additional namespaces like ghcr.io/kamu-data-dev, because namespace has to match the GH account. Should we instead change the image name to kamu-dev-api-server and use kamu-dev consistently as a prefix for dev builds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to clearly separate prod and dev images and I think tag is insufficient because

Good idea, I agree -- также, я добавил тоже самое и для kamu-cli (kamu-data/kamu-cli#969), please take a look.

Should we instead change the image name to kamu-dev-api-server and use kamu-dev consistently as a prefix for dev builds?

Yes, done

@s373r s373r changed the title kamu-api-server: error if specialized config is not found + kamu-api-server:dev images kamu-api-server: error if specialized config is not found + kamu-dev-api-server: image Nov 22, 2024
@s373r s373r requested a review from sergiimk November 22, 2024 15:20
@@ -0,0 +1,12 @@
ARG KAMU_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nitpick:

CLI image lives in the directory images/kamu-base-dev so mb for consistency let's use image/api-server-dev too?

I prefer things that are closely related to be close to each other lexicographically, so suffixing is better.

PS: I know that we also chose prefixing for actual image names (kamu-dev-api-server) but I see this as top-level separation of dev vs prod images.

Copy link
Member

@sergiimk sergiimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment 👍
(linked the image to repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants