-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kamu-api-server
: error if specialized config is not found + kamu-dev-api-server:
image
#149
base: master
Are you sure you want to change the base?
Conversation
s373r
commented
Oct 18, 2024
•
edited
Loading
edited
kamu-api-server
: error if specialized config is not found +
kamu-api-server
: error if specialized config is not found + kamu-api-server
: error if specialized config is not found + kamu-api-server:dev
images
images/api-server-dev/Makefile
Outdated
cp ../../target/$(TARGET)/release/kamu-api-server tmp/kamu-api-server | ||
docker build \ | ||
--build-arg KAMU_VERSION=$(KAMU_VERSION) \ | ||
-t $(IMAGE_REPO)/kamu-api-server:$(TAG) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like us to clearly separate prod and dev images and I think tag is insufficient because:
- Dev image uploads will relate to the same GH "package" as prod images
- Harder for users to see the version history
- If there will be ever image push notifications - we'll be spamming people with dev builds
- Makes it harder to clean up dev images over time - will need some tag-based regexes
In GHCR we cannot create additional namespaces like ghcr.io/kamu-data-dev
, because namespace has to match the GH account. Should we instead change the image name to kamu-dev-api-server
and use kamu-dev
consistently as a prefix for dev builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like us to clearly separate prod and dev images and I think tag is insufficient because
Good idea, I agree -- также, я добавил тоже самое и для kamu-cli
(kamu-data/kamu-cli#969), please take a look.
Should we instead change the image name to kamu-dev-api-server and use kamu-dev consistently as a prefix for dev builds?
Yes, done
915ab5a
to
14c623d
Compare
kamu-api-server
: error if specialized config is not found + kamu-api-server:dev
imageskamu-api-server
: error if specialized config is not found + kamu-dev-api-server:
image
14c623d
to
548ce62
Compare
@@ -0,0 +1,12 @@ | |||
ARG KAMU_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nitpick:
CLI image lives in the directory images/kamu-base-dev
so mb for consistency let's use image/api-server-dev
too?
I prefer things that are closely related to be close to each other lexicographically, so suffixing is better.
PS: I know that we also chose prefixing for actual image names (kamu-dev-api-server
) but I see this as top-level separation of dev vs prod images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment 👍
(linked the image to repo)