Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno implementation of MAL #546

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

graeme-lockley
Copy link

Hi,

I have created a Deno implementation of MAL. The code itself is Typescript and therefore you might elect to see it as another Typescript implementation however, the cool thing with Deno, is there is no package management - you simply type

deno run --allow-all step.ts

it then it just runs.

All of the tests pass, self hosting, docker image and the travis script runs.

Very keen to hear your thoughts and comments.

Thank you so much for creating and maintaining MAL!

@kanaka
Copy link
Owner

kanaka commented Apr 21, 2021

@graeme-lockley sorry for the slow response. I don't think the use of deno is itself enough justification for adding the implementation to the main tree. However, if you can make an argument that your implementation is different in some interesting way then I would definitely consider merging it into the tree. Examples: more idiomatic, different but well accepted style of TypeScript code, better performance in some aspect, more portable, etc. Basically, the purpose of having implementations in the main repo is pedagogical; for reference and comparison (both between languages and between implementations in the same language).

Alternately, I am always happy to mention your implementation in the README even if I don't end up merging it.

Also, some implementations have multiple modes (the *_MODE variables). If you want to extend the current typescript implementation to be modal and have a "deno" mode I would be happy to consider merging that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants