Fix Mac Workspaces Switching #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeseMueller
reviewed
Jul 7, 2024
| @@ -488,6 +494,10 @@ export class KandoApp { | |||
| // fullscreen applications. | |||
| this.window.setAlwaysOnTop(true, 'screen-saver'); | |||
|
|
|||
| // We set the Activation Policy to Accessory so that Kando doesn't show in dock | |||
| // or the CMD Tab App Switcher | |||
| app.setActivationPolicy('accessory') | |||
There was a problem hiding this comment.
I think this is mac exclusive, a non-mac user needs to test it.
See this documentation
There was a problem hiding this comment.
Got it. Added a commit with a condition which should make it mac-only.
Schneegans
requested changes
Jul 7, 2024
src/main/app.ts
Outdated
Comment on lines
383
to
387
| // Ensure the window is on the current worksspace before showing | ||
| this.window.setVisibleOnAllWorkspaces(true, { skipTransformProcessType: true }); | ||
| setTimeout(() => { | ||
| this.window.setVisibleOnAllWorkspaces(false, { skipTransformProcessType: true }); | ||
| }, 100); |
There was a problem hiding this comment.
As this does not seem to be required on Linux, I would prefer if that was only done on macOS. So maybe move this before the if (process.platform !== 'win32') { into an if (process.platform === 'darwin' {?
Also, you could mention #461 in the comment so that we know in the future where this weirdo comes from 😄
There was a problem hiding this comment.
Done. Pushed a new commit with the change 👍️
Schneegans
approved these changes
Jul 8, 2024
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #461.