Apply mkrasnitski/polarbits' suggestions

kangalio · Oct 30, 2023 · 3b5ecdd · 3b5ecdd
1 parent ab4f552
commit 3b5ecdd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/http/client.rs b/src/http/client.rs
@@ -15,7 +15,7 @@ use secrecy::{ExposeSecret, SecretString};
 use serde::de::DeserializeOwned;
 use tracing::{debug, instrument, trace};
 
-use super::multipart::Multipart;
+use super::multipart::{Multipart, MultipartUpload};
 use super::ratelimiting::Ratelimiter;
 use super::request::Request;
 use super::routing::Route;
@@ -26,7 +26,6 @@ use super::{
     HttpError,
     LightMethod,
     MessagePagination,
-    MultipartUpload,
     UserPagination,
 };
 use crate::builder::CreateAttachment;
@@ -490,7 +489,7 @@ impl Http {
             request.body = Some(to_vec(map)?);
         } else {
             request.multipart = Some(Multipart {
-                upload: MultipartUpload::Attachments(files.into_iter().map(Into::into).collect()),
+                upload: MultipartUpload::Attachments(files),
                 payload_json: Some(to_string(map)?),
                 fields: vec![],
             });
@@ -690,7 +689,7 @@ impl Http {
             request.body = Some(to_vec(map)?);
         } else {
             request.multipart = Some(Multipart {
-                upload: MultipartUpload::Attachments(files.into_iter().map(Into::into).collect()),
+                upload: MultipartUpload::Attachments(files),
                 payload_json: Some(to_string(map)?),
                 fields: vec![],
             });
@@ -1523,9 +1522,7 @@ impl Http {
             request.body = Some(to_vec(map)?);
         } else {
             request.multipart = Some(Multipart {
-                upload: MultipartUpload::Attachments(
-                    new_attachments.into_iter().map(Into::into).collect(),
-                ),
+                upload: MultipartUpload::Attachments(new_attachments),
                 payload_json: Some(to_string(map)?),
                 fields: vec![],
             });

diff --git a/src/http/multipart.rs b/src/http/multipart.rs
@@ -22,7 +22,7 @@ pub enum MultipartUpload {
     Attachments(Vec<CreateAttachment>),
 }
 
-/// Holder for multipart body. Contains files, multipart fields, and payload_json for creating
+/// Holder for multipart body. Contains upload data, multipart fields, and payload_json for creating
 /// requests with attachments.
 #[derive(Clone, Debug)]
 pub struct Multipart {