Skip to content

chore: update dependencies #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

chore: update dependencies #1153

wants to merge 1 commit into from

Conversation

j9t
Copy link

@j9t j9t commented Apr 23, 2024

Bumped dependencies by some simple npm audit fix. Though according to npm, this fixed 12 of 15 vulnerabilities, 3 persist; left it there for this update.

Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
@j9t
Copy link
Author

j9t commented Apr 23, 2024

Btw, when testing, I ran into some issues with ESLint. If not already in progress or pointed out elsewhere, should be worth looking into. html-minifier is using a now deprecated way of configuring ESLint; still, the current issues may be treatable by adding and adjusting

"parserOptions": {
  "ecmaVersion": "latest"
},

in the config.)

@GintasS
Copy link

GintasS commented Oct 1, 2024

Hi there. Thank you for your work. Do you think your PR fixes this CVE?

https://www.mend.io/vulnerability-database/CVE-2022-37620

@DanielRuf
Copy link

@GintasS no, since the relevant code (see my comments in the relevant issue) is in this package and not one of its dependencies.

@j9t
Copy link
Author

j9t commented Jun 1, 2025

Quick side note, I had already taken the silence here and no updates in the slightly more up-to-date html-minifier-terser to fork that and spin another version of html-minifier: html-minifier-next (npm).

It’s already more up-to-date, it works, I use it with 3 projects, but I’m still slow to announce its availability. Sharing if others like to test and contribute 🤝

@DanielRuf
Copy link

I think the problem still exists there: https://github.com/j9t/html-minifier-next/blob/8b5c3f7f39fd69fbd1d9ab11bc3412f0ec0f04e4/src/htmlminifier.js#L891

See my analysis starting at #1135 (comment).

So until this vulnerable regular expression is not changed (meaning: gets some upper limits or some other change to prevent this ReDoS), even the fork may be vulnerable (actually not tested by me).

I'm not an active contributor and maintainer anymore, but if you need some input for this just let me know.

@j9t
Copy link
Author

j9t commented Jun 1, 2025

@DanielRuf, thanks! Not my domain expertise but I’ve thrown some tooling at a PR to, ideally, resolve that issue in html-minifier-next (and inform similar fixes): j9t/html-minifier-next#20. If you like to have a look at provide feedback, it would be appreciated! (Thanks already for the updates here!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants