add CLI tool to derive caBLE tunnel server domain #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
micolous
commented
Apr 17, 2023
micolous
commented
- cargo test has been run and passes
- documentation has been updated with relevant examples (if relevant)
micolous
added
enhancement
yaleman
previously approved these changes
Apr 17, 2023
yaleman
approved these changes
Apr 17, 2023
Firstyear
reviewed
Apr 17, 2023
| @@ -91,3 +91,7 @@ image = ">= 0.23.14, < 0.24" | |||
|
|
|||
| [build-dependencies] | |||
| openssl.workspace = true | |||
|
|
|||
There was a problem hiding this comment.
I think we need to talk in future about how to move these out of being examples, since there are multiple tools here that actually are good cli tools, and not examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.