Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL dependency update to support v3.x #340

Merged
merged 18 commits into from
Aug 30, 2023
Merged

OpenSSL dependency update to support v3.x #340

merged 18 commits into from
Aug 30, 2023

Conversation

yaleman
Copy link
Member

@yaleman yaleman commented Aug 11, 2023

Fixes #339

  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

Firstyear
Firstyear previously approved these changes Aug 13, 2023
Copy link
Member

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from me, I'll let @micolous check too.

@dmulder
Copy link

dmulder commented Aug 16, 2023

I just tried building your branch on my machine with openSSL 3.1.2 and it still fails with the exact same error:

error[E0599]: no associated item named `NO_CHECK_TIME` found for struct `X509VerifyFlags` in the current scope
    --> webauthn-rs-core/src/attestation.rs:1279:49
     |
1279 |             .set_flags(verify::X509VerifyFlags::NO_CHECK_TIME)
     |                                                 ^^^^^^^^^^^^^
     |                                                 |
     |                                                 associated item not found in `X509VerifyFlags`
     |                                                 help: there is an associated constant with a similar name: `USE_CHECK_TIME`

@Firstyear
Copy link
Member

libopenssl-devel-3.1.2-1.1.noarch

Seems to be working on my tumbleweed machine? Also confirmed it works on my mac with 3.1.2 as well.

Do you potentially have a second openldap/libressl present?

@dmulder
Copy link

dmulder commented Aug 17, 2023

Do you potentially have a second openldap/libressl present?

Yes, I have libressl.

@Firstyear
Copy link
Member

Ahh that'll be it. libressl is broken wrt to openssl-rs normally, so it's likely a missing feature/flag/const in libressl.

Makefile Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
fido-hid-rs/src/lib.rs Outdated Show resolved Hide resolved
@yaleman
Copy link
Member Author

yaleman commented Aug 29, 2023

@micolous I've reverted what fmt changes I can and I don't have enough git-foo to convince the others to calm themselves, I hope that's OK.

@micolous
Copy link
Collaborator

Thanks! CI failures on MSRV look like a separate issue not triggered by this change, I've opened #346 about this.

@yaleman yaleman merged commit 908b2d9 into master Aug 30, 2023
46 of 66 checks passed
@yaleman yaleman deleted the yaleman/issue339 branch August 30, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSSL dependency update to support v3.x
4 participants