Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fido-key-manager: disable tests #358

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

micolous
Copy link
Collaborator

@micolous micolous commented Oct 3, 2023

fido-key-manager requires elevation on Windows:

  • For simplicity, this is declared in the application's manifest, included at link time. Elevation is handled by the platform before it calls .main.
  • There are ways to conditionally elevate actions, but this is much more complicated to implement. The only thing this tool which doesn't require elevation is --help, so this is much simpler.

cargo can't launch binaries requiring elevation. There's also no way to detect at a build.rs level whether a binary target will be used for a test, and conditionally disable elevation support.

There's no tests in fido-key-manager anyway – so this just disables them explicitly so that a project-wide cargo test won't fail on Windows.

@micolous micolous merged commit 13dc8b6 into kanidm:master Oct 3, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants