Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win10: fix incorrect user entity encoding #363

Merged
merged 1 commit into from
Oct 11, 2023
Merged

win10: fix incorrect user entity encoding #363

merged 1 commit into from
Oct 11, 2023

Conversation

micolous
Copy link
Collaborator

@micolous micolous commented Oct 6, 2023

WinUserEntityInformation encoded User::id as Base64 – that's not right!

  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@micolous micolous added bug Something isn't working win10 Issues related to Windows WebAuthn API labels Oct 6, 2023
@micolous micolous mentioned this pull request Oct 6, 2023
Closed
2 tasks
@micolous micolous merged commit 35cc2c3 into kanidm:master Oct 11, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firstyear Firstyear Firstyear approved these changes

@yaleman yaleman Awaiting requested review from yaleman yaleman is a code owner

@agrinman agrinman Awaiting requested review from agrinman agrinman is a code owner

Assignees
No one assigned
Labels
bug Something isn't working win10 Issues related to Windows WebAuthn API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micolous @Firstyear