Implement some SoloKeys2/Trussed vendor commands #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micolous
requested review from
Firstyear,
yaleman and
agrinman
as code owners
Firstyear
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements some vendor-specific SoloKeys 2 (Trussed) vendor-specific commands:
These commands all operate at a
U2FHidFramelayer, so this also adds a bunch of plumbing to make that all work.I've tested these with SoloKeys Solo 2 and NitroKey 3A over USB HID. I've tried a few other keys, and they appear to ignore these commands without any issues, but due to the nature of vendor commands this is all very difficult to manage.
I haven't implemented NFC support as that's been very unreliable.