Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fixing documentation in CI #392

Merged
merged 5 commits into from
Nov 24, 2023
Merged

WIP: fixing documentation in CI #392

merged 5 commits into from
Nov 24, 2023

Conversation

micolous
Copy link
Collaborator

@micolous micolous commented Nov 24, 2023

  • Move DEFAULT_AUTHENTICATOR_TIMEOUT into webauthn-rs, and make authenticator_timeout a required parameter for webauthn_rs_core::Webauthn::unsafe_experts_only.

    • Moves default timeouts into our recommended interface, so that the value of that default isn't hidden behind internal interfaces.
    • Fixes a documentation build breakage caused by Feature/configurable timeout #385.
    • Changes the default timeout from 1 minute to 5 minutes, per Webauthn-3 recommendations.
    • Adds accessibility and UX concerns to the timeout documentation.
  • Add PhantomData to webauthn_authenticator_rs::stubs.

    Sometime in the last few months, has been a change in Rust Nightly which makes unused type parameters a hard error when documenting; and we rely on Nightly for doc_cfg and doc_auto_cfg on docs.rs.

Fixes #

  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

This fixes a documentation build breakage caused by kanidm#385, and shifts
default timeouts into our recommended interface.
@Firstyear Firstyear merged commit fd5648d into kanidm:master Nov 24, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants