Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20231215 264 cleanup #400

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

Firstyear
Copy link
Member

Fixes #264 - this cleans up some of the older "safe" interfaces in core since they now all belong in webauthn-rs. This removes some old comments and also hides some modules. Finally some other functions are moved to more contextually relevant places.

  • [ x ] cargo test has been run and passes
  • [ x ] documentation has been updated with relevant examples (if relevant)

@Firstyear Firstyear marked this pull request as draft December 15, 2023 04:06
@Firstyear Firstyear marked this pull request as ready for review December 15, 2023 04:32
webauthn-rs/src/lib.rs Outdated Show resolved Hide resolved
webauthn-rs/src/lib.rs Outdated Show resolved Hide resolved
webauthn-rs/src/lib.rs Outdated Show resolved Hide resolved
webauthn-rs/src/lib.rs Outdated Show resolved Hide resolved
webauthn-rs-core/src/core.rs Show resolved Hide resolved
webauthn-rs-core/src/core.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@micolous micolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures look pre-existing (#407), which can be handled here or in a follow-up PR.

@Firstyear Firstyear merged commit f40f95f into kanidm:master Dec 30, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup of core library
2 participants