Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EDDSA support #408

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Add EDDSA support #408

merged 3 commits into from
Jan 1, 2024

Conversation

Firstyear
Copy link
Member

Fixes #399 - Adds eddsa support

  • [ x ] cargo test has been run and passes
  • [ x ] documentation has been updated with relevant examples (if relevant)

yaleman
yaleman previously approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me

@Firstyear
Copy link
Member Author

CI error appears to be clippy, I haven't updated to 1.75 yet. I'll do that next.

micolous
micolous approved these changes Jan 1, 2024
View reviewed changes
Copy link
Collaborator

@micolous micolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also got rid of some duplicated code :)

Clippy issues are logged in #407 and can be handled in another PR.

@Firstyear Firstyear merged commit f4c363e into kanidm:master Jan 1, 2024
32 of 33 checks passed
@Firstyear Firstyear deleted the 20231229-eddsa branch January 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micolous micolous micolous approved these changes

@yaleman yaleman yaleman left review comments

@agrinman agrinman Awaiting requested review from agrinman agrinman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add EdDSA capabilities
3 participants
@Firstyear @yaleman @micolous