Add build-time OpenSSL version checks #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
webauthn-rs
OpenSSL policy is currently only "enforced" forwebauthn-authenticator-rs
.This PR adds OpenSSL version number checks to
attestation-ca
andwebauthn-rs-core
usingOPENSSL_VERSION_NUMBER
. Every other package in this repo with an OpenSSL dependency depends on one of these two packages, so can be handled transitively.This will make builds fail with OpenSSL v1.x, in line with our OpenSSL policy.
OpenSSL alternatives
We don't currently support OpenSSL alternatives, but I've attempted to avoid breaking them with this PR:
OPENSSL_VERSION_NUMBER
to whichever it's targetting, so doesn't need special casing.rust-openssl
doesn't expose the LibreSSL version, and LibreSSL doesn't target parity with specific OpenSSL versions.I haven't tested with either.
What failures look like
When building with outdated OpenSSL, this PR now makes it so you get a build-time error: